Skip to content

Add a GNU build id to workhorse binaries

Bob Van Landuyt requested to merge bvl-workhorse-gnu-build-id into master

What does this MR do and why?

This adds a GNU build id to workhorse binaries when compiling.

The build id is based on the current tag if there is an exact match for the HEAD. When the directory is dirty, a timestamp is also included.

When there is no exact match to a tag, we fall back to a random id.

This build id is used by perf to match symbols to the binary, not having them could cause incorrect or incomplete profiles.

gitlab-com/gl-infra/scalability#1464 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Bob Van Landuyt

Merge request reports