Skip to content

Make starrers sort dropdown Pajamas compliant

Mark Florian requested to merge 348737-haml-listbox-helper into master

What does this MR do and why?

This adds HAML and JavaScript helpers for simple single-select listbox dropdowns (most commonly used for sorting). The sort dropdown in the starrers page is also re-implemented with it.

See #348737 (comment 808527160) for the overall rationale of the approach taken here.

Addresses #348737 (closed) and part of #263187 (closed).

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

  1. Visit a project which has been starred, and visit its starrers page, e.g., /gitlab-org/gitlab-test/-/starrers

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Florian

Merge request reports

Loading