Skip to content

Better memoize instance level variables when creating pipelines

Marius Bobin requested to merge ci-cache-instance-level-variables into master

What does this MR do and why?

Without this change each call to secret_instance_variables would:

  • trigger a Redis call to check that the cache is still valid
  • transform the variables from active record objects into variables items, possibly having some decryption overhead.
The plan
Refactor instance secret variables !79435 (merged) this one
Refactor project secret variables !79850 (merged)
Refactor group secret variables !79936 (merged)
Bundle them under a single method !79935 (merged)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marius Bobin

Merge request reports

Loading