Skip to content

Don't return 500 error for tags in atom format

Vasilii Iakliushin requested to merge fix_atom_error_when_gitaly_unavailable into master

What does this MR do and why?

Sentry error: https://sentry.gitlab.net/gitlab/gitlabcom/issues/3152896

Problem

When Gitaly is unavailable, tags atom requests return a 500 error.

Solution

Return 503 (Service unavailable error) instead

How to set up and validate locally

  1. Stop gitaly gdk stop gitaly
  2. Open link: http://127.0.0.1:3000/flightjs/Flight/-/tags?format=atom
  3. You should see 503 error, instead of 500.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vasilii Iakliushin

Merge request reports