Skip to content

Refactor Security Config page after backend has been unified for CE & EE

Jannik Lehmann requested to merge jnnkl-security-config-refactor into master

What does this MR do and why?

This MR is meant to solve: #333113 (closed)

Before this MR the all of the configuration-data for the Security Configuration Page in FOSS was hardcoded on the client side. For the EE version the configuration-data for the Security Configuration Page was accumulated through the dynamic data object in the template and augmented with static data from the clientside code.

This MR changes the approach, it removes some of the hardcoded configuration-data for the Security-Configuration Page in FOSS and ensures that all of the Security-Config Pages no matter what license they're on are accumulated with data through the same approach as used in FOSS before. So we can eventually merge the .haml templates together and only have one template for the security configuration page no matter the license. This page will then be dynamically configured through the BE (this will be done in another MR).

Disclaimer: all of the Screenshots have been taken from the same project.

Screenshots or screen recordings (no visual changes)

FOSS/CE

before after
master-ce_foss Screenshot_2022-02-10_at_11.05.57

ULTIMATE/EE

before after
master-ee_ultimate branch-ce_ultimate

NO LICENSE/EE

before after
Screenshot_2022-02-02_at_18.37.30 Screenshot_2022-02-10_at_11.12.49

How to set up and validate locally

  1. go to http://gitlab.localdev:3000/USER/PROJECT/-/security/configuration for FOSS and EE without License and with ultimate License

The easiest way to swap between FOSS and EE is the env.runit file in the gdk root folder

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports

Loading