Skip to content

Replace certificate delete confirmation modal

Lukas Eipert requested to merge 344159-fix-delete-certificate-modal into master

What does this MR do and why?

This replaces the GitLab Pages confirmations modals with GlModal

Screenshots or screen recordings

what before after
Certificate deletion Screenshot_2022-01-31_at_16.59.36 Screenshot_2022-01-31_at_17.54.16
Domain deletion Screenshot_2022-01-31_at_18.02.13 Screenshot_2022-01-31_at_17.54.28
Pages deletion Screenshot_2022-01-31_at_18.02.17 Screenshot_2022-01-31_at_17.54.35

How to set up and validate locally

Not entirely sure anymore, but maybe like this: Enable Pages with https locally in the GDK. Instructions https

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344159 (closed)

Edited by Lukas Eipert

Merge request reports

Loading