Skip to content

Ensure legacy viewer is loaded when highlight.js FF disabled + general cleanup

Jacques Erasmus requested to merge highlight_js_ff into master

What does this MR do and why?

Ensures that we only load highlight.js behind a FF (being worked on in this epic)

This MR also does some general cleanup in the refactored blob viewer.

changes in this MR are behind the :refactor_blob_viewer feature flag.

Screenshots or screen recordings

viewer screenshot
download Screenshot_2022-02-02_at_09.34.48
image Screenshot_2022-02-02_at_09.39.08
video Screenshot_2022-02-02_at_09.41.15
text Screenshot_2022-02-02_at_09.30.48
pdf Screenshot_2022-02-02_at_09.44.27
lfs Screenshot_2022-02-02_at_09.52.04

How to set up and validate locally

  1. Enable the Blob Viewer Refactor feature flag
Feature.enable(:refactor_blob_viewer)
  1. Open a file in the repository file browser

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jacques Erasmus

Merge request reports

Loading