Skip to content

Use docker pause instead of stop to minimise test downtime

John McDonnell requested to merge jmd-improve-gitaly-e2e-stop-start-times into master

What does this MR do and why?

Replace using docker stop with docker pause for the Gitaly E2E tests.

For a number of test scenarios we need to test the behaviour when the system is in a degraded state.
In the current implementation of the tests we achieve this by stopping the docker containers and later restarting them. However this means that the praefect and gitaly services need to start up before we have a healthy system again to continue the test suite, taking an estimated 30-60 secs extra.
By using pause instead we can simulate the same behaviour of the system, without needing to actually restart the services themselves saving time on execution.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by John McDonnell

Merge request reports