Skip to content

Fix projects dark mode colors

Coung Ngo requested to merge cngo-fix-project-page-dark-mode-colours into master

What does this MR do and why?

This MR fixes dark mode on the projects page. The issue was caused by failing to use CSS variables for the colours when moving global CSS to page bundles in !79842 (merged)

Screenshots or screen recordings

Before !79842 (merged) After !79842 (merged) After the dark mode fix in this MR
Screenshot_2022-02-06_at_10-50-42_H5bp_Html5_Boilerplate Screenshot_2022-02-06_at_10-57-01_H5bp_Html5_Boilerplate Screenshot_2022-02-06_at_11-07-05_H5bp_Html5_Boilerplate

How to set up and validate locally

  1. Change theme to dark mode alpha in user preferences
  2. Check a project page, e.g. http://127.0.0.1:3000/h5bp/html5-boilerplate/

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading