Skip to content

Fix merge requests page dark mode

Coung Ngo requested to merge cngo-fix-merge-requests-dark-mode into master

What does this MR do and why?

This MR fixes dark mode on the merge requests page. The issue was caused by failing to use CSS variables for the colours when moving global CSS to page bundles in !79897 (merged)

Screenshots or screen recordings

Before !79897 (merged) After !79897 (merged) After the dark mode fix in this MR
Screenshot_2022-02-06_at_10-50-05_Et_ea_similique_labore_nostrum_placeat_et_aliquam_optio___4____Merge_requests___H5bp_Html_..._ Screenshot_2022-02-06_at_10-56-56_Et_ea_similique_labore_nostrum_placeat_et_aliquam_optio___4____Merge_requests___H5bp_Html_..._ Screenshot_2022-02-06_at_11-46-05_Et_ea_similique_labore_nostrum_placeat_et_aliquam_optio___4____Merge_requests___H5bp_Html_..._

How to set up and validate locally

  1. Change theme to dark mode alpha in user preferences
  2. Check a merge requests page, e.g. http://127.0.0.1:3000/h5bp/html5-boilerplate/-/merge_requests/1

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports