Skip to content

Fix error when using invalid sort on issues list refactor

Coung Ngo requested to merge cngo-fix-issues-list-sort into master

What does this MR do and why?

This MR fixs an error when using an invalid sort on the group/project issues list Vue refactor.

Using an invalid sort such as sort=asdf throws an error that prevents the group/project issues list from rendering the list.

This change is behind the feature flag vue_issues_list defaulted to off.

Screenshots or screen recordings

How to set up and validate locally

  1. In rails console enable the feature flag
    Feature.enable(:vue_issues_list)
  2. Visit a group/project issues list pages with an invalid sort, e.g. http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues/?sort=asdf&state=opened
  3. Confirm that the issues list shows and there are no console errors

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading