Skip to content

Replace `data-confirm` modals with `GlModal` in group hooks

What does this MR do and why?

Update the confirmation button variant to danger and its label to Delete on delete group hook confirmation modal.

Screenshots or screen recordings

Without FF With FF (before) With FF (after)
Screen_Shot_2022-02-08_at_10.27.30_AM Screen_Shot_2022-02-08_at_10.26.36_AM Screen_Shot_2022-02-09_at_12.21.36_PM

How to set up and validate locally

  1. Enable the bootstrap_confirmation_modals feature flag: Feature.enable(:bootstrap_confirmation_modals)
  2. Login as admin
  3. Go to a group > Settings > Webhooks
  4. If there isn't a webhook already, create one by filling the form and clicking Add webhook
  5. Click 'Edit' next to one of the group hooks on the list
  6. Click Delete

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344205 (closed)

Edited by Vamsi Vempati

Merge request reports

Loading