Resolve "Replace `data-confirm` modals with `GlModal` in `app/views/projects/hooks/edit.html.haml`"
requested to merge 344170-replace-data-confirm-modals-with-glmodal-in-app-views-projects-hooks-edit-html-haml into master
What does this MR do and why?
Update the confirmation button variant to danger
and its label to Delete
on delete project hook confirmation modal.
Screenshots or screen recordings
Without FF | With FF (before) | With FF (after) |
---|---|---|
How to set up and validate locally
- Enable the
bootstrap_confirmation_modals
feature flag:Feature.enable(:bootstrap_confirmation_modals)
- Login as admin
- Go to a project > Settings > Webhooks
- If there isn't a webhook already, create one by filling the form and clicking
Add webhook
- Click 'Edit' next to one of the group hooks on the list
- Click
Delete
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #344170 (closed)
Edited by Vamsi Vempati