Fix cross modification table for GroupDestroyWorker
requested to merge mo-groupdestroyworker-causing-crossdatabasemodificationacrossunsupportedtableserror into master
Ref: #352209 (closed)
What does this MR do and why?
This MR removes our dependent destroy ActiveRecord
callback for Project#builds
.
Why are we doing this?
We have a loose foreign key defined in our build table which will take care of cleaning up those records.
We are leveraging the database to delete in cascade associated build records for a given project rather than using ActiveRecord which has some poor performance implication.
See this blog post for the full explanation.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Max Orefice