Skip to content

Fix create - render - destroy lifecycle for gitlab experiment

Serhii Yarynovskyi requested to merge sy-trial-status-widget-dont-show-primary-action into master

What does this MR do and why?

Our Ultimate Trial Status widget is oscillating between displaying 1 and 2 CTAs. It should display 2 at all times.

Solution

Our <gitlab-experiment> tag relies on $slots. And after first appearance $slots are empty until page is refreshed. Replaced with $scopedSlots.

Screenshots or screen recordings

Screen_Recording_2022-02-08_at_11.44.08

How to set up and validate locally

  1. Login as an active trial user or login as regular user and go to /-/trials/new to activate trial.
  2. Go to any group or create new one. Hover over the Ultimate trial status widget at the top of the left hand side nav.
  3. Both CTAs (Upgrade to Ultimate and Compare All Plans) will appear.
  4. Take your cursor elsewhere, the widget will close. Leave for 10-15 seconds
  5. Revisit the widget and still 2 CTA should appear.

Related to #352189 (closed)

Edited by Serhii Yarynovskyi

Merge request reports