Skip to content

Feature/link_phabricator_project

Mehmet Gürcan requested to merge MGurcan/git-lab:master into master

What does this MR do and why?

The problem I worked on was related to Phabricator projects linking to a Task. (based on the issue: #28091 (closed) ) To solve it; I have created some labels for Phabricator Projects by some changes on Gitlab::PhabricatorImport::Representation::Task :

def project_phids
  json['attachments']['projectPHIDs']
end

Then, when I' am checking the similar codes related to this labelling, I've seen that it is doing a roughly similar thing for finding authors and assignees for an issue. in: Gitlab::PhabricatorImport::Issues::TaskImporter#execute So, based on this information I've tried to make similar changes on Gitlab::PhabricatorImport::Issues::TaskImporter:

if variable = find_issue_by_phabricator_id(task.phabricator_id)
            issue.project_phids << variable
end 

Comments

This project was my first open-source try and also this merge request was my first MR. That is why my first aim was to check how to make some merge requests and learn to contribute to open-source projects. Thanks to @reprazent 's suggestions I have made some research related to Phabricator projects and learned a lot. I will keep learning and working on it.

Edited by Mehmet Gürcan

Merge request reports

Loading