Skip to content

Make sure #eql? will not raise when type unmatched

Lin Jen-Shin requested to merge eql-should-not-raise into master

What does this MR do and why?

This is in respond to #352248 (closed) where using eql? raises an exception because the other value is not the expected type.

This is not the fix to the flaky test because it's not expected to pass this value, but using == (an alias of eql? in this case) should not raise an exception. Breaking this assumption may break storing this in a Hash as well.

Screenshots or screen recordings

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports