Stop confetti popup from opening on browser back button
What does this MR do and why?
- keeps the confetti popup modal from opening on browser back button
- switches from rails session cookies to regular cookies so they can be referenced in javascript that is re-rendered on page load.
Screenshots or screen recordings
no modal popup when back button used
Screen_Recording_2022-02-10_at_3.25.52_PM
How to set up and validate locally
-
Enable the
confetti_post_signup
Feature.enable(:confetti_post_signup)
-
Register as a new user by visiting
http://localhost:3000/users/sign_up
(or by clickingRegister now
fromhttp://localhost:3000/users/sign_in
) -
Answer
Just me
on thehttp://localhost:3000/users/sign_up/welcome
page(no other fields need filled out/changed) -
Click
Continue
-
On the next few screens, fill out new Group and Project names.
-
Wait for the
Get Started with GitLab
to finish. -
Click
Ok, let's go
. -
Observe invite modal open on next screen.
-
Close the modal.
-
Click a link on the page.
-
Click the browser back button.
-
Ensure modal doesn't open again.(before this change it did)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.