Resolve "[Storage] [Feature flag] Remove the 'new_route_storage_purchase' feature flag"

What does this MR do and why?

Removes new_route_storage_purchase feature flag as the feature is deemed stable on production.

Screenshots or screen recordings

Feature	Screenshot
Buy storage takes us to the right link
Loads the GitLab checkout flow in the same window
Storage purchase from personal namespace points to CDot flow
[Regression testing] Minutes purchase from personal namespace points to CDot flow

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #337720 (closed)