Skip to content

Refactor project import service spec to stub provider without details

Peter Leitzen requested to merge pl-project-import-service-spec into master

What does this MR do and why?

It seems that the stubbed provider variable is not used to verify import behaviour, so let's not stub it with too many details.

Note that this was caught because we've passed a Hash with String keys to ActiveSupport::InheritableOptions whereas Symbol keys are expected.

Came up during a post-review of !75280 (comment 847633646) or the review of !75277 (comment 847620251).

How to set up and validate locally

Run:

bin/rspec spec/services/projects/import_service_spec.rb -e "with valid importer"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading