Skip to content

Setting the cleaner diff for ipynb as default

Eduardo Bonet requested to merge make-cleaner-diffs-default into master

What does this MR do and why?

MR !75500 (merged) adds the cleaner diff as the secondary view, even though the cleaner diff is a lot more useful than the raw one, which is there for edge cases. We are hiding the optimal experience for the user in order to add an option, which goes against our works by default mentality.

This MR sets the cleaner diff as the main one

Since this a follow up on a feature being added on 14.9, no changelog was added

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Create a mirror of https://gitlab.com/gitlab-org/incubation-engineering/mlops/ipynb-test-projects/diff-sample into your GDK instance (include branches main and branch_with_another_change
  2. Enable the feature flag :rendered_diffs_viewer
  3. Open the commit 2352a32d5b88ff26ee348798e7cbaef047176ce6 (http://gdk.test:3000/<path-to-mirror>/-/commit/2352a32d5b88ff26ee348798e7cbaef047176ce6)
  4. On the right side of each file, the selected by default should be the cleaner diff

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Bonet

Merge request reports