Skip to content

Remove last data-remote script execution in codebase

Mark Florian requested to merge 353340-remove-custom-project-templates-remote-script-execution into master

What does this MR do and why?

This changes the new-project-from-template flow to avoid data-remote JavaScript execution.

This is a minimum viable change for addressing #353339 (closed) and #353340 (closed), which are blocking #336138 (closed).

These endpoints now return HTML fragments instead of JavaScript; there should be no difference in behaviour as far as the user is concerned.

Screenshots or screen recordings

Before After
NO CHANGE IN BEHAVIOUR
before after

How to set up and validate locally

  1. Set up custom instance-level project templates
  2. Set up custom group-level project templates
  3. Visit https://gdk.test:3000/projects/new
  4. Click on Create from template
  5. See that clicking into the instance and group tabs displays the templates, and you can page through them

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Florian

Merge request reports