Skip to content

Add dispensable_render methods

Alex Buijs requested to merge add-dispensable_render-method into master

What does this MR do and why?

When a partial that contains an error is included on every page of the application, GitLab could be rendered inaccessible completely.

To avoid such a situation, these helper methods are added to log errors and render nothing instead.

Use these methods only when rendering inessential partials, like for displaying banners or messages.

The idea was taken from Fabio's comment here: https://gitlab.com/gitlab-org/gitlab/-/issues/353188#note_849876258 in response to an incident with broadcast messages.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alex Buijs

Merge request reports

Loading