Replace bootstrap Dropdown to gitlab-ui Dropdown
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR will solve: #348606 (closed)
- bootstrap legacy dropdown is substituted with GlDropdown
- Static dropdown uses default version of dropdown
- Dropdown with search and async data loading is replaced with 'with search version'
- GlLoadingIcon is used explicitly because built-it
loading prop
for dropdown doesn't look similar to required design - Legacy dropdown is removed with according test (it is not used anywhere else)
- Async data loading for template list happens only when dropdown opens, only when
show
event is used, nottoggle
.
Screenshots or screen recordings
before |
---|
after |
---|
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Go to project files /root/$PROJECT/
- Select any file (.gitlab-ci.yml for better example)
- Click Edit in Web IDE.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Artur Fedorov