Skip to content

Ensure shared groups are displayed as project member

What does this MR do and why?

This merge request fixes the display of the Project members page. On that page, groups that are shared with a parent group are currently not shown when viewing a project's members.

Add a new argument to the function which creates the member JSON object which takes in a list of group_group_links.

Partly fixes: #219230 (closed)

Screenshots or screen recordings

tg2 is a subgroup with a shared group with reporter access called tg1:

image

A repository under tg2 called test reports that there are no groups with notable permissions: image

With the fix, the Groups tab properly is displayed: image

Steps to replicate

  1. Create groups, tg1 and tg2
  2. Invite tg1 group to tg2 group, verify presence on tg2 members page
  3. Create repository, test, under tg2 group,
  4. See absence of "Groups" tab on member page of test

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Joe Snyder

Merge request reports

Loading