Skip to content

Ensure static objects URL is correctly formatted for Download button

Jacques Erasmus requested to merge 351555-static-object-urls into master

What does this MR do and why?

This ensures that the static objects URL is correctly set for the blob header Download button

⚠ changes in this MR are part of the :refactor_blob_viewer feature flag.

Screenshots or screen recordings

No visual changes are expected

before after
notice the extra ? in the URL ? is replaced with &
Screenshot_2022-03-04_at_05.49.06 Screenshot_2022-03-04_at_05.49.19

How to set up and validate locally

  1. Enable the Blob Viewer Refactor feature flag
Feature.enable(:refactor_blob_viewer)
  1. Navigate to static objects settings (Admin > Settings > Repository > External storage for repository static objects)
  2. Define a URL and Authentication token
  3. Open any file from the repository file browser in a private project
  4. Notice the URL for the download button

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #351555 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports