Skip to content

Migrate SAML SSO spinner to be Pajamas-compliant

Peter Hegman requested to merge 353771-make-spinners-in-ee-app-views-groups-sso-saml-html-haml-pajamas-compliant into master

What does this MR do and why?

Related to #353771 (closed)

Migrate spinner shown when reauthenticating via SAML to be Pajamas-compliant.

No visual changes, so no changelog.

Screenshots or screen recordings

No visual changes

Before After
Screen_Recording_2022-03-04_at_3.32.07_PM Screen_Recording_2022-03-04_at_3.29.48_PM

How to set up and validate locally

Setting up SAML in GDK can be tricky. This is a trivial change that I have verified locally so it is probably not worth the time for a reviewer to set this up. That said, if you're up for the challenge here are the steps :grinning::

  1. Setup SAML SSO: https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/master/doc/howto/saml.md
  2. Use the "GitLab single sign-on URL" found in /groups/example-group/-/saml in an Incognito window to login. You may need to go into "Admin" -> "Users" and manually confirm the user.
  3. Change the DEFAULT_SESSION_TIMEOUT constant to DEFAULT_SESSION_TIMEOUT = 30.seconds
  4. Wait 30 seconds
  5. Refresh the page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports