Skip to content

Add DB reindexing Grafana config as application settings

Krasimir Angelov requested to merge 332696-db-reindeixng-grafana-app-settings into master

What does this MR do and why?

First step into solving #332696 (closed).

This introduces new application settings to store Grafana key/url/tag that will be used when creating annotations during database reindexing. These settings will eventually replace the environment variables used now. With this MR settings will be used if present, and will fallback to environment variables if not.

The issue suggests we move this to GitLab config, but generated config/gitlab.yml says "This file should not receive new settings" and recommends using ApplicationSetting model - https://gitlab.com/gitlab-org/gitlab/-/blob/835d3421ff8685cdc834cb5d57dde9916cb94c5d/config/gitlab.yml.example#L6-10, hence I decided to go with application settings.

There are no UI changes in this MR, this will be done in a separate MR, if we decide we need them.

We'll also need CR to update the settings with the values from the environment variables currently used.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #332696 (closed)

Merge request reports