Skip to content

New Project page: allow to hide deployment target question

Jonas Wälter requested to merge siemens/gitlab:new-project-page/hide-deployment-target2 into master

What does this MR do and why?

Introduced in !79873 (merged), there's a 'Project deployment target' question on the Create Project page. That's very similar to the 'personalization questions' on the Create Group page. As the 'personalization questions' can be hidden (implemented in !76920 (merged), this should also be possible for the 'Project deployment target' question on the Create Project page

So this MR binds the showing/hiding of the 'Project deployment target' questions to the Admin Area > General > Customer experience improvement and third-party offers setting.

🛠 with ❤ at Siemens

/cc @bufferoverflow

Screenshots

Setting: disabled Setting: enabled
image image

How to set up and validate locally

  1. Visit the General settings in the Admin area and uncheck Do not display content for customer experience improvement and offers from third parties in the Customer experience improvement and third-party offers section: http://localhost:3000/admin/application_settings/general#js-third-party-offers-settings
  2. Visit New Project page: http://localhost:3000/projects/new#blank_project
    ➡ The deployment question is displayed.
  3. Visit the General settings in the Admin area and check Do not display content for customer experience improvement and offers from third parties in the Customer experience improvement and third-party offers section: http://localhost:3000/admin/application_settings/general#js-third-party-offers-settings
  4. Visit New Project page: http://localhost:3000/projects/new#blank_project
    ➡ The deployment question is hidden.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jonas Wälter

Merge request reports