Skip to content

Remove reliance on Flash styling

Alex Buijs requested to merge 353432-remove-reliance-on-flash-styling-within-ee-app-views-trials-_errors-html-haml into master

What does this MR do and why?

Replace Flash styling in Haml with a Vuejs FlashAlert component on The new trial page and The apply trial page.

Screenshots or screen recordings

The new trial page:

before after
Screen_Shot_2022-03-09_at_14.33.17 Screen_Shot_2022-03-17_at_10.47.15

The apply trial page:

before after
Screen_Shot_2022-03-09_at_16.15.10 Screen_Shot_2022-03-17_at_10.46.24

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Simulate GitLab.com (echo "export GITLAB_SIMULATE_SAAS=1" > env.runit in gdk directory and gdk restart rails-web)
  2. Visit the new trial page: http://localhost:3000/-/trials/new
  3. Fill in the form
  4. Click Continue
  5. Visit the apply trial page: http://localhost:3000/-/trials/select
  6. Fill in the form
  7. Click Start your free trial

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

closes #353432 (closed)

Edited by Alex Buijs

Merge request reports