Skip to content

Refactor(Groups SSO): migrate to gl-tabs

What does this MR do and why?

This MR migrates the Groups SSO tabs to a Pajamas-compatible implementation using the gl_tabs_nav helper. There is a slight pixel difference, but that is to be expected with the change to use the Pajamas-compatible implementation.

Screenshots or screen recordings

Before After
Screen_Shot_2022-03-09_at_17.03.48 Screen_Shot_2022-03-09_at_17.03.36
Screen_Recording_2022-03-09_at_16.28.00 Screen_Recording_2022-03-09_at_15.59.34

How to set up and validate locally

The best way to see this is to add a byebug statement in the sso_spec.rb and run the test with CHROME_HEADLESS=false spring rspec ee/spec/features/groups/sso_spec.rb -e 'SAML response includes a verified email from the logged in user'. I've added a patch for you with the byebug statement here: add-byebug-to-sso-spec.patch.

The test will stop where the tabs are visible and you can interact with them both from the master branch and this MR's branch to see them properly there.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #230764 (closed)

Edited by Michael Lunøe

Merge request reports

Loading