Skip to content

Migrate seats_count_alert to global_alert

Diana Zubova requested to merge dz/354597-migrate-seats-count-alert into master

What does this MR do and why?

Update ee/app/views/layouts/header/_seats_count_alert.html.haml to leverage the shared alert HAML partial (app/views/shared/_global_alert.html.haml).

Mind that we still want to render it as Page Level alert https://design.gitlab.com/components/alert#placement

Related to #354597 (closed)

Screenshots or screen recordings

No visible change

Screenshot_2022-03-14_at_14.32.48

How to set up and validate locally

  1. The fastest way to test it locally is to enable the alert for every group. Please update the seats_count_alert_helper.rb#L28 so show_seats_count_alert? always returns true
  2. Visit any group page such as http://localhost:3000/flightjs/

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Diana Zubova

Merge request reports

Loading