Skip to content

Rescue Geo after_{create,destroy} hooks on regular models

Catalin Irimie requested to merge cat-geo-rescue-after-commit-hook-errors into master

What does this MR do and why?

As a corrective action, this prevents possible errors in Geo logic from saving or destroying the models as expected, and can cause silent failures if that happens.

(previous example of this causing problems was silently dropping LFS files on import, causing a severity1 data loss bug)

Related to #352387 (closed).

How to set up and validate locally

I think tests should make this clear enough, but one could change handle_after_create_commit to raise StandardError and try to attach a file to an issue - this would fail before, but work after this MR.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports