Skip to content

Fix hanging specs when decomposed

Thong Kuah requested to merge fix_more_decomposed_hanging_specs into master

What does this MR do and why?

Fix hanging specs when decomposed

This is due to a Rails bug causing where FactoryBot thread, and Puma thread are stuck with each other waiting for the load_interlock_aware_monitor lock.

The fix is to ensure no Puma threads ocurr when FactoryBot factories are being created. Here it is done by moving the visits to within the spec, after the factory creation.

Previously the visits were in the before hook, which meant async requests ran concurrently with factories.

Fixes #355960 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports