Skip to content

Migrate to shared alert in projects deletion_failed

What does this MR do and why?

Migrate to shared alert in app/views/projects/_deletion_failed.html.haml.

Part of &5213 (closed).

Screenshots or screen recordings

before after
Screen_Shot_2022-03-17_at_11.01.24 Screen_Shot_2022-03-17_at_11.01.48

How to set up and validate locally

  1. Navigate to a project page
  2. In app/views/projects/_deletion_failed.html.haml, uncomment the second line and observe the warning alert at the top of the page
  3. Alternatively, apply this patch
diff --git a/app/views/projects/_deletion_failed.html.haml b/app/views/projects/_deletion_failed.html.haml
index b713b805009..5af3159ea0a 100644
--- a/app/views/projects/_deletion_failed.html.haml
+++ b/app/views/projects/_deletion_failed.html.haml
@@ -1,5 +1,5 @@
 - project = local_assigns.fetch(:project)
-- return unless project.delete_error.present?
+-# - return unless project.delete_error.present?
 
 = render 'shared/global_alert', variant: :warning, dismissible: false, alert_class: 'project-deletion-failed-message' do
   .gl-alert-body

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #325365 (closed)

Edited by Ammar Alakkad

Merge request reports

Loading