Skip to content

Remove an unused scope from Ci::JobArtifact

drew stachon requested to merge remove-artifact-order-expired-desc-scope into master

What does this MR do and why?

This MR removes a scope from Ci::JobArtifact that we no longer use. It used to be used in the process of removing expired artifacts, but that's since been rewritten and now artifacts are either either without an explicit order or with expired_at: :asc, changed in !76509 (merged)

Note: We still do technically query artifacts by descending order of expiration, but we do in a (deprecated) method that we already have a feature flag in place to move away from, and use ActiveRecord directly there instead of using this scope.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by drew stachon

Merge request reports