Skip to content

Remove feature flag gitaly_backup

James Fargher requested to merge remove_ff_gitaly_backup into master

What does this MR do and why?

#333034 (closed)

  • There haven't been any errors for gitaly-backup that required changes for a couple of releases now. So this MR removes the legacy code and feature flag.
  • The legacy concurrency code would have been unused. So this gets deleted too.

How to set up and validate locally

There is no new feature to test here. Just regression.

  1. Take a backup 
    $ bundle exec rake gitlab:backup:create
...
2022-03-17 13:17:11 +1300 -- Creating backup archive: 1647476196_2022_03_17_14.9.0-pre_gitlab_backup.tar ... done
...
  2. Restore a backup. Note that BACKUP does not take a path, it is the name of the tar file without the suffix _gitlab_backup.tar. 
    $ bundle exec rake gitlab:backup:restore BACKUP=1647476196_2022_03_17_14.9.0-pre

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by James Fargher

Merge request reports