Skip to content

Drop CI builds triggered by blocked user

Stan Hu requested to merge sh-drop-blocked-user-build into master

What does this MR do and why?

When a user is blocked, typically Ci::DropPipelineService will cancel the builds. However, there's a chance that this service doesn't pick up all the cancelable builds at the time it is run. To ensure that builds aren't actually run for a blocked user, we add it to a precondition before we assign a runner.

Thanks to @mbobin for this idea in https://gitlab.com/gitlab-org/gitlab/-/issues/351294#note_876734970.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/351294

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marius Bobin

Merge request reports