Move merge request approvals out of EE
requested to merge 231351-optional-merge-request-approvals-do-not-send-email-notifications into master
What does this MR do and why?
It was pointed out in #231351 (closed) that GitLab Core has the approve action for merge requests but doesn't have notifications for participants that an MR was approved/unaprpoved. This moves that functionality over from EE.
How to set up and validate locally
- Setup a CE installation locally
- Create a merge request
- With another user, approve the merge request
- Check to make sure the original user got a notification
- Repeat for unapproving a notification
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #231351 (closed)
Edited by Gary Holtz