Skip to content

Add CSS class for UserAvatarInline rendered with `GlAvatar`

What does this MR do and why?

Pre-history: The feature flag gl_avatar_for_all_user_avatars was introduced in !81437 (merged) to migrate all avatars implementations to GlAvatar. The FF and related code will be deleted when all instances will be checked with FF enabled. This specific MR was targeted to prepare UserAvatarList to use GlAvatar in its implementation. I hoped to use GlUserAvatarsInline component but it lacks some functionality. So UserAvatarList component still uses UserAvatarLink (as before) which relies on UserAvatarImage which internally uses GlAvatar.

Related epic is here

So what does this MR do?

Most of the work was done in 2 previous MRs !81437 (merged) && !82736 (merged). UserAvatarList can be switched to using GlAvatar by enabling the feature flag gl_avatar_for_all_user_avatars. We only need some spacing between the avatars so the CSS class is added for that behind the FF.

Screenshots or screen recordings

With FF (avatar size adhusted to be valid 24px) Without FF
2022-03-21_18.34.55 2022-03-21_18.32.17

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Olena Horal-Koretska

Merge request reports

Loading