Skip to content

Fix credentials detection for UrlSanitizer

Vasilii Iakliushin requested to merge fix_import_credentials into master

What does this MR do and why?

Contributes to #347562 (closed)

Problem

We ignore raw credentials from URL if credentials are explicitly provided as a hash to UrlSantizer.new(url, credentials: { user: <user>, password: <password> }).

Solution

Collect credentials from both URL and credentials hash. Values from credentials hash have preference.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vasilii Iakliushin

Merge request reports

Loading