Skip to content

Set an approval rule to deployment approval

Shinya Maeda requested to merge dep-approval-multi-access-levels-rails into master

What does this MR do and why?

This MR adds the Internal logic for Multi Access Levels in Deployment Approval.

  • Extend Deployments::ApprovalService (The SSOT service that users can approve/reject deployment) to set ProtectedEnvironments::ApprovalRule to Deployments::Approval.
  • Delete both ProtectedEnvironments::DeployAccessLevel and ProtectedEnvironments::ApprovalRule when an assigned group/user has been removed from the protected environment.
  • Add deployment_approval_rules feature flag to shut out the new logic until all MRs have been merged.

These internal logic will be used in an upcoming MR. Please see PoC MRs - PoC 1, PoC 2 for the overview.

A few notes:

Screenshots or screen recordings

N/A (See the manual QA result of PoC)

How to set up and validate locally

N/A (See the manual QA result of PoC)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports

Loading