Fix error flash is hidden when updating issue repeatedly
requested to merge gitlab-jh/jh-team/gitlab:fix-error-flash-is-hidden-when-updating-issue into master
What does this MR do and why?
closes #356942 (closed)
Screenshots or screen recordings
before | after |
---|---|
How to set up and validate locally
- mock
updateIssuable
inapp/assets/javascripts/issues/show/services/index.js
and give a422
http status code and a json response like{"errors":["Description sensitive or illegal characters involved"]}
- edit an existing issue, click
save changes
button. - error flash will be shown, click
save changes
button again. - error flash will still be shown.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Kun Qian