Skip to content

Cache Gitaly also based on lib/gitlab/setup_helper.rb

Lin Jen-Shin requested to merge cache-gitaly-with-helper into master

What does this MR do and why?

Cache Gitaly also based on lib/gitlab/setup_helper.rb because it might produce different binary based on how we try to configure Gitaly.

See #357096 (closed)

The theory is that !83750 (merged) updated the configuration generation, which can lead to different Gitaly binary being built and stored in the cache.

This should make sure generated Gitaly binary cache always stay with respect to which version and which configuration generation.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lin Jen-Shin

Merge request reports

Loading