Add global_search_users_tab feature flag
What does this MR do and why?
Closes: #357553 (closed)
This adds an ops
feature flag global_search_users_tab
for the users
tab in global search. It is set to be enabled by default to match the behavior that we have now. We can choose to disable the users
scope in global searches after this is merged by disabling the feature flag.
The reason why we would want to do this is that there is currently quite a bit of load on the database from global searches for users, but the content of the search queries clearly do not have good intentions.
To see some examples of these searches (which result in quite long response times): https://log.gprd.gitlab.net/goto/4eeeeb30-b1cf-11ec-afaf-2bca15dfbf33 (internal link)
Screenshots or screen recordings
search level | screenshot |
---|---|
global search | |
group search | |
project search |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.