Skip to content

Draft: Resolve user popover not displaying on compliance report

Jiaan Louw requested to merge 357388-bug-avatar-tooltips-don-t-populate-and-throw-an-error into 346266-feature-flag-enable-compliance-violations-report

What does this MR do and why?

Resolves the user popover not displaying when hovering over user avatars or links on the compliance report for #357388 (closed).

Changes made:

  1. Resolves the popover not displaying by converting the GraphQL id to a regular id.
  2. Resolves the popover showing the wrong user popover by re-rendering the avatar link component when the key changes.

Screenshots or screen recordings

Before After
image image

Screen_Recording_2022-04-04_at_12.51.03

How to set up and validate locally

  1. Go to [GDK_HOST]/groups/[GROUP]/-/security/compliance_dashboard
  2. Validate that the user popover is shown when hovering over a user avatar or link.
    • If no violations are shown then you can run FILTER=compliance_report_violations rake db:seed_fu to populate violations locally
  3. Validate that the violation drawer shows the correct popover by clicking on the violation rows.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jiaan Louw

Merge request reports