Skip to content

Update to use name field for training url graphql query

Samantha Ming requested to merge 357727-use-name-for-training-url-query into master
Changes MR
BE !84313 (merged)
FE this MR

What does this MR do and why?

In this MR, we are updating the frontend to pass the name field instead of the externalId 👍

Background Info

We initially relied on the externalId to make the API call to our provider. However we noticed this field data doesn't always provide the information we require, please see > #357008

Here is an instance, where the externalId is not what we need. Example > https://gitlab.com/stefania-demo/nodejs/-/security/vulnerabilities/39727260

image

So the backend MR > !84313 (merged) has updated their logic to handle and parse the more reliable name field and use it to make the vendor API request 👍

Screenshots or screen recordings

This MR does not introduce any UI/UX changes.

How to set up and validate locally

  1. Please make sure you have enabled the security training feature, docs; please enable both vendors.
  2. Navigate to the vulnerability page to view the training link, docs
  3. Note, we currently only support cwe identifiers.
  4. We are making the graphql query with the identifier name, NOT externalId
The identifier name Passing the identifier name (NOT externalId)
2022-04-07_at_6.03_PM 2022-04-07_at_6.01_PM

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #357727 (closed)

Edited by Samantha Ming

Merge request reports

Loading