Improve sidebar attn. requests with better source code
What does this MR do and why?
- When attention requests are turned off, the sidebar reviewers and assignees layout is still stable
- When attention requests are on, the side bar reviewers/assignees code is easier to read
How
First of all, this more appropriately defines the grid columns so that if the attention requests are disabled, the grid still flows properly.
Then, this switches to named grid areas instead of "magic" column numbers. Instead of magically swapping column numbers, semantic HTML is assigned to a grid region. This region is defined in the CSS, so the region never changes, only where the region is depending on the feature flag.
Screenshots or screen recordings
| Before | After | |
|---|---|---|
mr_attention_requests enabled |
 |
 |
mr_attention_requests disabled |
 |
 |
As a bonus - since all of the above were also stress-testing how it looks with super long text - here's what it looks like after the changes in this MR when the user has more typical text size:
mr_attention_requests disabled |
mr_attention_requests enabled |
|---|---|
 |
 |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.