Skip to content

Raise an error if repo storage name is blank

Mark Lapierre requested to merge ml-forbid-blank-repo-storage-name into master

What does this MR do and why?

Prevents false positives that can occur if a test fabricates a project and intends to set a specific repository storage but doesn't provide the storage name.

Requires !84679 (merged) to be merged first to skip a test that shouldn't run on review apps.

Background

There are two tests that use praefect and require a storage name to be set. One of them failed recently because it ran on an environment that doesn't have praefect. However, the other test didn't fail, which seems to be because the test framework silently ignored the blank value for repository_storage, and so the test used the default repository storage.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Lapierre

Merge request reports