Skip praefect tests on review apps
What does this MR do and why?
Skip praefect tests on review apps because the review apps don't use praefect (they use Gitaly standalone, not Gitaly Cluster).
The smoke tests pass because of a false positive (which will be fixed in !84674 (merged)).
Test results
To confirm that the praefect tests are excluded, we can see that a recent master
pipeline includes 23 smoke tests on Review Apps, but there are only 22 in this MR:
- 23 smoke tests in
master
: https://gitlab.com/gitlab-org/gitlab/-/jobs/2381104304#L2367 - 22 smoke tests in this MR: https://gitlab.com/gitlab-org/gitlab/-/jobs/2381135695#L2281
We can also see one test from qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb
does run as expected:
But the other smoke test in the same file with the name pushes to a project using a specific Praefect repository storage
isn't included in the job because it has the requires_praefect
metadata.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.